Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear ENV["XDG_CONFIG_HOME"] to avoid loading user-defined irbrc in test #982

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Clear ENV["XDG_CONFIG_HOME"] to avoid loading user-defined irbrc in test #982

merged 1 commit into from
Jul 18, 2024

Conversation

tompng
Copy link
Member

@tompng tompng commented Jul 17, 2024

TestIRB::ConfigValidationTest#setup forgot to clear ENV['XDG_CONFIG_HOME']

With these environment variables, rake test fails.

echo "puts 'IRBRC'; exit" > /path/to/dummy_home/env_irbrc
echo "puts 'HOME'; exit" > /path/to/dummy_home/.irbrc
echo "puts 'XDG'; exit" > /path/to/dummy_home/.config/irb/irbrc
IRBRC=/path/to/dummy_home/env_irbrc HOME=/path/to/dummy_home/ XDG_CONFIG_HOME=/path/to/dummy_home/.config rake test

Test passes with normal irbrc content maybe with Error loading RC file warning message, but it's better not to read user-defined irbrc file.

olleolleolle
olleolleolle reviewed Jul 18, 2024
View reviewed changes
test/irb/helper.rb Outdated Show resolved Hide resolved
@tompng tompng merged commit 632da0f into ruby:master Jul 18, 2024
30 checks passed
@tompng tompng deleted the test_clear_xdg_env branch July 18, 2024 10:56
matzbot pushed a commit to ruby/ruby that referenced this pull request Jul 18, 2024
@tompng @matzbot
[ruby/irb] Clear ENV["XDG_CONFIG_HOME"] to avoid loading
c304bf1 
user-defined irbrc in TestIRB::ConfigValidationTest
(ruby/irb#982)

ruby/irb@632da0ff29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olleolleolle olleolleolle olleolleolle left review comments

@st0012 st0012 st0012 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tompng @olleolleolle @st0012